From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9719B3858D28 for ; Tue, 7 Dec 2021 20:35:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9719B3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-k08h4PNpOm-V4GlAD1h4fg-1; Tue, 07 Dec 2021 15:35:56 -0500 X-MC-Unique: k08h4PNpOm-V4GlAD1h4fg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E00C100F94A; Tue, 7 Dec 2021 20:35:55 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-7.rdu2.redhat.com [10.10.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12FAE13A58; Tue, 7 Dec 2021 20:35:54 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 1B7KZsqI3312729; Tue, 7 Dec 2021 15:35:54 -0500 From: DJ Delorie To: Patrick McGehearty Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2] Remove upper limit on tunable MALLOC_MMAP_THRESHOLD In-Reply-To: <6baba8a1-99da-bea4-ab51-ea77ba1946a9@oracle.com> Date: Tue, 07 Dec 2021 15:35:54 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 20:36:00 -0000 Patrick McGehearty writes: > DJ, does your final comments mean this patch is > OK to commit? Sorry, yes. Please commit. > I should say that I intend to also change HEAP_MAX to be > a tunable to handle the issues we discussed as a separate > patch. It does not look to be time consuming. I just > can't predict when I'll have it ready because it's behind > a couple of other things in my task list and I can't > predict what new work tasks might cause further delays. Please pay attention to the performance metrics on that one; you're replacing a compiled-in constant (with associated masks and shifts, which may not be obviously dependent) with a runtime computation, and we do those computations a lot. Otherwise, good luck ;-)