From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 95B7038312AC for ; Mon, 27 Jun 2022 18:57:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 95B7038312AC Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-67-EFBKTmMeNU-GZssMGBSYew-1; Mon, 27 Jun 2022 14:57:48 -0400 X-MC-Unique: EFBKTmMeNU-GZssMGBSYew-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C7C813C025C3; Mon, 27 Jun 2022 18:57:47 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.8.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B304D2026D64; Mon, 27 Jun 2022 18:57:47 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 25RIvk2D039893; Mon, 27 Jun 2022 14:57:46 -0400 From: DJ Delorie To: Xi Ruoyao Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] test-container: return UNSUPPORTED for ENOSPC on clone() In-Reply-To: Date: Mon, 27 Jun 2022 14:57:46 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2022 18:57:51 -0000 > + /* ALT Linux has an alternate way of doing the same. */ > + { "/proc/sys/kernel/unprivileged_userns_clone", 0, 1, 0 }, Those two lines should be swapped, as the comment refers to this following line: > + { "/proc/sys/kernel/userns_restrict", 1, 0, 0 }, LGTM to commit with that change. Reviewed-by: DJ Delorie