From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 23A22385840F for ; Tue, 5 Apr 2022 18:20:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 23A22385840F Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-85-cC18wfJNNi66RVNvo9RePQ-1; Tue, 05 Apr 2022 14:20:19 -0400 X-MC-Unique: cC18wfJNNi66RVNvo9RePQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5B4093802133; Tue, 5 Apr 2022 18:20:19 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-4.rdu2.redhat.com [10.10.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43A0514583DA; Tue, 5 Apr 2022 18:20:18 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 235IKHxU152209; Tue, 5 Apr 2022 14:20:17 -0400 From: DJ Delorie To: Joseph Myers Cc: carlos@redhat.com, libc-alpha@sourceware.org Subject: Re: [patch v6] Allow for unpriviledged nested containers In-Reply-To: Date: Tue, 05 Apr 2022 14:20:17 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 18:20:22 -0000 Maybe we need a Hurd trybot? ;-) I see two options: #ifdef the variable, or mark it attribute-unused. Preferences? diff --git a/support/test-container.c b/support/test-container.c index c837c4d7580..79d0e052d1c 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -756,7 +756,9 @@ main (int argc, char **argv) /* If set, the test runs as root instead of the user running the testsuite. */ int be_su = 0; int require_pidns = 0; +#ifdef CLONE_NEWNS const char *pidns_comment = NULL; +#endif int do_proc_mounts = 0; int UMAP; int GMAP; @@ -1046,8 +1048,10 @@ main (int argc, char **argv) else if (nt >= 1 && strcmp (the_words[0], "pidns") == 0) { require_pidns = 1; +#ifdef CLONE_NEWNS if (nt > 1) pidns_comment = concat_words (the_words + 1, nt - 1); +#endif } else if (nt == 3 && strcmp (the_words[0], "mkdirp") == 0) {