From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8A2B33858C27 for ; Tue, 8 Feb 2022 03:51:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A2B33858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-461-crSZV0ioO6aaqoOtG3QI8w-1; Mon, 07 Feb 2022 22:51:11 -0500 X-MC-Unique: crSZV0ioO6aaqoOtG3QI8w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 249741923E20 for ; Tue, 8 Feb 2022 03:51:10 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-3.rdu2.redhat.com [10.10.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7398E73A; Tue, 8 Feb 2022 03:51:02 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 2183p1S82856151; Mon, 7 Feb 2022 22:51:01 -0500 From: DJ Delorie To: "Carlos O'Donell" Cc: libc-alpha@sourceware.org, fweimer@redhat.com Subject: Re: [PATCH 2/2] localedata: Do not generate output if warnings were present. In-Reply-To: <20220205025700.3728228-3-carlos@redhat.com> (libc-alpha@sourceware.org) Date: Mon, 07 Feb 2022 22:51:01 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 03:51:14 -0000 "Carlos O'Donell via Libc-alpha" writes: > diff --git a/localedata/Makefile b/localedata/Makefile > $(INSTALL-SUPPORTED-LOCALE-ARCHIVE): install-locales-dir > - @flags="-c"; \ > $(build-one-locale) Ok. (or do we set this to "" ?) > $(INSTALL-SUPPORTED-LOCALE-FILES): install-locales-dir > - @flags="-c --no-archive --no-hard-links"; \ > + @flags="--no-archive --no-hard-links"; \ > $(build-one-locale) Ok. > diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh > -# Run quietly and force output. > -flags="--quiet -c" > +# Do not force output with '-c', all locales should compile without > +# warning or errors. There is likewise no need to run quietly with > +# '--quiet' since all locales should compile without additional > +# diagnostics. If there are messages printed then we want to see > +# them, fix them, and the associated error or warning. During > +# development it may be beneficialy to put '--quiet -c' here to allow > +# you to develop in-progress locales. > +flags="" Ok, but this assumes that all locales are fully defined, with no fields left to their defaults. LGTM Reviewed-by: DJ Delorie