From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rhel8.vm.delorie.com (d-159-250-13-23.nh.cpe.atlanticbb.net [159.250.13.23]) by sourceware.org (Postfix) with ESMTPS id E81413858C27 for ; Fri, 5 Mar 2021 01:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E81413858C27 Received: from rhel8.vm.redhat.com (localhost [127.0.0.1]) by rhel8.vm.delorie.com (8.15.2/8.15.2) with ESMTPS id 12511xUL036619 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 4 Mar 2021 20:01:59 -0500 From: DJ Delorie To: Szabolcs Nagy Cc: libc-alpha@sourceware.org, Richard.Earnshaw@arm.com Subject: Re: [PATCH 05/16] malloc: Avoid taggig mmaped memory on free In-Reply-To: (message from Szabolcs Nagy on Thu, 4 Mar 2021 16:31:36 +0000) Date: Thu, 04 Mar 2021 20:01:59 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, KAM_DMARC_NONE, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, RDNS_DYNAMIC, SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 01:02:04 -0000 Szabolcs Nagy writes: > Either the memory belongs to the dumped area, in which case we don't > want to tag (the dumped area has the same tag as malloc internal data > so tagging is unnecessary, but chunks there may not have the right > alignment for the tag granule), or the memory will be unmapped > immediately (and thus tagging is not useful). LGTM Reviewed-by: DJ Delorie