From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110235 invoked by alias); 2 Nov 2018 16:56:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 110221 invoked by uid 89); 2 Nov 2018 16:56:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com From: DJ Delorie To: fweimer@redhat.com (Florian Weimer) Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] support/shell-container.c: Use support_copy_file_range In-Reply-To: <20181102151721.11C294399457D@oldenburg.str.redhat.com> (fweimer@redhat.com) Date: Fri, 02 Nov 2018 16:56:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00055.txt.bz2 fweimer@redhat.com (Florian Weimer) writes: > * support/shell-container.c (copy_func): Call > support_copy_file_range instead of copy_file_range to support > cross-device copies. I'm kinda surprised HJ didn't do this when he added support_copy_file_range itself, since this is WHY we added that. Regardless, LGTM. Reviewed-by: DJ Delorie