From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-103569-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 75657 invoked by alias); 9 Jul 2019 18:07:05 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 75649 invoked by uid 89); 9 Jul 2019 18:07:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mx1.redhat.com
From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] test-in-container: Install locales into the test container
In-Reply-To: <874l3vf70k.fsf@oldenburg2.str.redhat.com> (message from Florian Weimer on Tue, 09 Jul 2019 19:32:43 +0200)
Date: Tue, 09 Jul 2019 18:07:00 -0000
Message-ID: <xnbly3qdyy.fsf@greed.delorie.com>
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2019-07/txt/msg00197.txt.bz2

Florian Weimer <fweimer@redhat.com> writes:
> The testing time impact of this change is significant: It increases
> total test time from ~13 to ~15 minutes for me.  However, I do not
> see any other way to run locale-dependent tests in a container.

This is also the only way to auto-test "make install-locales" too :-)

>  	$(MAKE) install DESTDIR=$(objpfx)testroot.pristine
> +	$(MAKE) localedata/install-locales DESTDIR=$(objpfx)testroot.pristine
>  	touch $(objpfx)testroot.pristine/install.stamp

This matches what's documented in INSTALL so LGTM.

Reviewed-by: DJ Delorie <dj@redhat.com>