Re: [patch v4] manual: add syscall list

[DJ Delorie <dj@redhat.com>]

"Zack Weinberg" <zack@owlfolio.org> writes:
>> +man_pages_version=6.8
>> +
>> +AC_ARG_WITH([man-pages],
>> +	    AS_HELP_STRING([--with-man-pages=VERSION],
>> +			   [tie manual to a specific man-pages version]),
>> +	    [man_pages_version=$withval],
>> +	    [])
>> +AC_SUBST(man_pages_version)
>> +
>>  AC_ARG_ENABLE([sanity-checks],
>>  	      AS_HELP_STRING([--disable-sanity-checks],
>>  			     [really do not use threads (should not be used except in 
>
> This is fine as is.  I might suggest a tiny change: instead of
> setting the default value for man_pages_version above the AC_ARG_WITH,
> set it in the action-if-not-given:

I started that way, but moved it out so it would be more obvious where
to change the value when the time comes.  This is the same thing we do
with the minimum kernel version, although in that case the default value
is spread across target-specific files.

> Also, I wonder if it makes sense to tie the default here to the
> default for --enable-kernel, assuming there is one.

--enable-kernel sets a minimum kernel version, whereas the man pages is
typically going to be the latest (maximum) version.

>> -if test ${ac_cv_prog_cxx_cxx11+y}
>> +if test ${ac_cv_prog_cxx_11+y}
>>  then :
> ...
>
> This looks like you didn’t use the same version of Autoconf as the
> last person to update configure.ac.  As I understand it we’re trying
> to stick to a constant version.  Check with Joseph Myers for what you
> should be using.

I used verison 2.71 (as noted in configure) right from the GNU ftp site.

The last time this line was changed, it was from
c6cb8783b5fb5896cb63fe9008b6a33351f3c777 which changed us from autoconf
2.69 to 2.71.

It turns out Fedora has added a patch to 2.71 that makes the '-' side of
the changes noted; which means that we can't use Fedora's autoconf if the
rule is (as documented) "GNU autoconf 2.71 (exactly)".

Or we need to change the rules.

  "If you change any of the 'configure.ac' files you will also need

     * GNU 'autoconf' 2.71 (exactly)"