From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9C128384F038 for ; Mon, 28 Jun 2021 18:52:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C128384F038 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-LEWFnZNKNIepM15rHuaLzw-1; Mon, 28 Jun 2021 14:52:06 -0400 X-MC-Unique: LEWFnZNKNIepM15rHuaLzw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9B58C73A5 for ; Mon, 28 Jun 2021 18:52:05 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-111.rdu2.redhat.com [10.10.112.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 791A1604CC; Mon, 28 Jun 2021 18:52:01 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 15SIq0CT558779; Mon, 28 Jun 2021 14:52:00 -0400 From: DJ Delorie To: "Carlos O'Donell" Cc: libc-alpha@sourceware.org Subject: Re: One test per line, one source per line, etc. etc. etc. In-Reply-To: Date: Mon, 28 Jun 2021 14:52:00 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 18:52:10 -0000 "Carlos O'Donell via Libc-alpha" writes: > Do we have consensus for someone to just cleanup all the makefiles > to have one source per line, one test per line etc.? Yes (again) :-) I have two comments: 1. I use some sort of end-of-list tag, like this: FILES = \ a.c \ b.c \ $(ENDOFLIST) or just $E or anything that expands to nothing. Remnants of an old job where adding the trailing \ to the previous line caused 100% patch conflicts. I'm not tied to any particular method, but I'm very against the omit-last-slash format. 2. I recommend the files NOT be listed in strict alphabetical order, when there's a large variance in build times. List the files that take longest, first. Comment it as such, of course. Leftovers from libiberty's builds, where a parallel make spent most of its time waiting for the ONE file that took forver to build, which was last in the alphabetical list, so was always built by itself.