From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dj@redhat.com>
Received: from rhel8.vm.delorie.com (d-159-250-13-23.nh.cpe.atlanticbb.net
 [159.250.13.23])
 by sourceware.org (Postfix) with ESMTPS id 0C430385801D
 for <libc-alpha@sourceware.org>; Fri,  5 Mar 2021 00:56:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C430385801D
Received: from rhel8.vm.redhat.com (localhost [127.0.0.1])
 by rhel8.vm.delorie.com (8.15.2/8.15.2) with ESMTPS id 1250uMER036566
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
 Thu, 4 Mar 2021 19:56:22 -0500
From: DJ Delorie <dj@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: libc-alpha@sourceware.org, Richard.Earnshaw@arm.com
Subject: Re: [PATCH 12/16] malloc: Use mtag_enabled instead of USE_MTAG
In-Reply-To: <a08289e4a58ff4ad00f0d61ebcdb1cdaca5dc3d5.1614874816.git.szabolcs.nagy@arm.com>
 (message from Szabolcs Nagy on Thu, 4 Mar 2021 16:33:42 +0000)
Date: Thu, 04 Mar 2021 19:56:22 -0500
Message-ID: <xneeguv2o9.fsf@rhel8.vm>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, KAM_DMARC_NONE,
 KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, RDNS_DYNAMIC, SPF_FAIL, SPF_HELO_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2021 00:56:27 -0000

Szabolcs Nagy <szabolcs.nagy@arm.com> writes:
> Use the runtime check where possible: it should not cause slow down in
> the !USE_MTAG case since then mtag_enabled is constant false, but it
> allows compiling the tagging logic so it's less likely to break or
> diverge when developers only test the !USE_MTAG case.

LGTM

Reviewed-by: DJ Delorie <dj@redhat.com>