From: DJ Delorie <dj@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: Do not use array parameter to new_composite_name (bug 26726)
Date: Fri, 30 Oct 2020 16:05:58 -0400 [thread overview]
Message-ID: <xneelfv5qx.fsf@greed.delorie.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2010281957130.233090@digraph.polyomino.org.uk> (message from Joseph Myers on Wed, 28 Oct 2020 19:57:29 +0000)
Joseph Myers <joseph@codesourcery.com> writes:
> is declared as an array with __LC_LAST elements, but when the category
> argument is not LC_ALL, it actually only has one element. Since the
Confirmed that new_composite_name() is only called twice; once with
LC_ALL and a large-enough array, and once without LC_ALL and a small array.
> -new_composite_name (int category, const char *newnames[__LC_LAST])
> +new_composite_name (int category, const char **newnames)
Ok.
LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>
prev parent reply other threads:[~2020-10-30 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 19:57 Joseph Myers
2020-10-30 20:05 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xneelfv5qx.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).