From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] _nss_nis_initgroups_dyn: Use struct scratch_buffer [BZ #18023]
Date: Mon, 25 Jun 2018 21:46:00 -0000 [thread overview]
Message-ID: <xnefguk09f.fsf@greed.delorie.com> (raw)
In-Reply-To: <7fdc44e1-6e74-9a11-678e-db3298ee3a87@redhat.com> (message from Florian Weimer on Mon, 25 Jun 2018 22:43:13 +0200)
Florian Weimer <fweimer@redhat.com> writes:
> You can free the buffer again, but you don't have to. There is no
> memory leak if you don't.
>
> The point here is not call free if we know it is a no-op.
>
> So I think the code is okay as-is.
Agreed, just checking ;-)
>> In this case, going to "done" *does* call scratch_buffer_free(). At
>> least we should be consistent within a given file ;-)
>
> Here we call the entire cleanup sequence, which happens to include
> scratch_buffer_free as well, so the situation is different.
Ok, as long as the inconsistency was intentional and reasoned, I'm OK
with it.
prev parent reply other threads:[~2018-06-25 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 17:49 Florian Weimer
2018-06-25 20:37 ` DJ Delorie
2018-06-25 20:43 ` Florian Weimer
2018-06-25 21:46 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnefguk09f.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).