From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85119 invoked by alias); 25 Oct 2016 21:55:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 85100 invoked by uid 89); 25 Oct 2016 21:55:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mallopt, sk:MALLOC_, malloc.h, malloch X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com From: DJ Delorie To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Document the M_ARENA_* mallopt parameters References: <1477318076-22231-1-git-send-email-siddhesh@sourceware.org> <1477318076-22231-3-git-send-email-siddhesh@sourceware.org> Date: Tue, 25 Oct 2016 21:55:00 -0000 In-Reply-To: <1477318076-22231-3-git-send-email-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Mon, 24 Oct 2016 19:37:56 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-10/txt/msg00440.txt.bz2 Siddhesh Poyarekar writes: > -/* Non public mallopt parameters. */ > #define M_ARENA_TEST -7 > #define M_ARENA_MAX -8 Hmmm... if these are now public, do they need to be moved elsewhere? Like, malloc.h ? > +The presence of multiple @code{arenas} allows multiple threads to allocate > +memory simultaneously in their own separate arenas, thus improving performance. Not quite true - there isn't one arena per thread, there are N arenas per M threads. Probably better to say "... simultaneously in separate arenas ..." > +environment variable @code{MALLOC_ARENA_TEST} to the desired value. > +@item M_ARENA_MAX Missing blank line. Otherwise, the content looks OK to me from a technical point of view.