From: DJ Delorie <dj@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, jan@mwa.re, fweimer@redhat.com
Subject: Re: [PATCH v3] Always define __USE_TIME_BITS64 when 64 bit time_t is used
Date: Thu, 14 Mar 2024 22:23:22 -0400 [thread overview]
Message-ID: <xnil1o8c85.fsf@greed.delorie.com> (raw)
In-Reply-To: <20240118131801.600373-1-adhemerval.zanella@linaro.org> (message from Adhemerval Zanella on Thu, 18 Jan 2024 10:18:01 -0300)
Sorry for the delay in this.
This looks like a mostly mechanical patch, but I have a few general
comments...
First, the patch no longer applies cleanly, but only because three
instances of __GLIBC_USE (ISOC2X) have been replaced with __GLIBC_USE
(ISOC23) in the context around your changes in time/time.h. I don't
consider this a problem with the patch, just making you aware.
Second, this new macro is not documented anywhere. Given the confusion
about the old macros, I think a comment in manual/maint.texi (@node
64-bit time symbol handling) or sysdeps/generic/features-time64.h would
be useful. Especially if it's not intended to be used outside of glibc,
yet is visible outside of glibc. It would be better if it could be made
to be not visible outside of glibc or glibc's headers, but...
Third, there are many cases of an if/else/endif clause where the change
was made to the if but not the else or endif:
./io/fcntl.h: #else /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/arm/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/arm/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/hppa/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/hppa/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/m68k/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/m68k/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/mips/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/mips/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/mips/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/powerpc/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/powerpc/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/sh/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/sh/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/sparc/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/sparc/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/x86/bits/struct_stat.h: #endif /* __USE_TIME_BITS64 */
./sysdeps/unix/sysv/linux/x86/bits/struct_stat.h: # endif /* __USE_TIME_BITS64 */
prev parent reply other threads:[~2024-03-15 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 13:18 Adhemerval Zanella
2024-01-27 13:54 ` Andreas K. Huettel
2024-01-29 16:29 ` Adhemerval Zanella Netto
2024-01-29 16:37 ` Andreas K. Huettel
2024-01-29 16:40 ` Florian Weimer
2024-01-31 12:34 ` Jonathan Wakely
2024-01-31 17:48 ` Adhemerval Zanella Netto
2024-03-15 2:23 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnil1o8c85.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=jan@mwa.re \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).