From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8992D3858C74 for ; Thu, 8 Sep 2022 19:49:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8992D3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662666598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=Ij12pcTn+QLkVi41gRoewmwQ+VqpvPD1x1kbIjZ4yzQ=; b=d0A9XYtEGzXLvJ+LeRRmPoRIq1KzPq8Zqi1bxqdcS3erFg73quyvlwinwYQ+pYN+SHIqLh 5RhVvMQFtcp9SmZwVH852C438ViXn3jP3SuuFCucLOuhDX8QVOnaTYCKGQixzjf9tTxXd9 Ndf+wUKHc7RniV1UwVhNVjlbKlkPc7Y= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-321-JOU6zJaQPcGdeIXAWzyP_g-1; Thu, 08 Sep 2022 15:49:57 -0400 X-MC-Unique: JOU6zJaQPcGdeIXAWzyP_g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFB283C0ED48; Thu, 8 Sep 2022 19:49:56 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.8.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB9351410F37; Thu, 8 Sep 2022 19:49:56 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 288Jnk2S1435116; Thu, 8 Sep 2022 15:49:46 -0400 From: DJ Delorie To: Wilco Dijkstra Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Use C11 atomics instead atomic_add(_zero) In-Reply-To: Date: Thu, 08 Sep 2022 15:49:46 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Wilco Dijkstra via Libc-alpha writes: > - atomic_add (&mp_.mmapped_mem, -total_size); > + atomic_fetch_add_relaxed (&mp_.mmapped_mem, -total_size); Ok. > - atomic_add (&noai6ai_cached.usecnt, 2); > + atomic_fetch_add_relaxed (&noai6ai_cached.usecnt, 2); Ok. > - && atomic_add_zero (&olddata->usecnt, -1)) > + && atomic_fetch_add_relaxed (&olddata->usecnt, -1) == 1) atomic_add_zero includes the comparison, so Ok. > - if (atomic_add_zero (&data->usecnt, -1)) > + if (atomic_fetch_add_relaxed (&data->usecnt, -1) == 1) Ok. LGTM Reviewed-by: DJ Delorie