Re: RFC V3 [1/2] test-in-container

[DJ Delorie <dj@redhat.com>]

Florian Weimer <fweimer@redhat.com> writes:
> On 03/02/2018 12:05 AM, DJ Delorie wrote:
>> +  sfd = open (sname, O_RDONLY);
>> +  if (sfd < 0)
>> +      error (EXIT_UNSUPPORTED, errno,
>> +	     "unable to open %s for reading\n", sname);
>> +
>> +  if (stat (sname, &st) < 0)
>> +      error (EXIT_UNSUPPORTED, errno,
>> +	     "unable to stat %s\n", sname);
>
> Should this be fstat64?

Probably :-)

>> +  dfd = open (dname, O_WRONLY | O_TRUNC | O_CREAT, 0600);
>> +  if (dfd < 0)
>> +    error (EXIT_UNSUPPORTED, errno,
>> +	   "unable to open %s for writing\n", dname);
>
> EXIT_UNSUPPORTED does not appear to be correct here.  These should be 
> hard failures IMHO.

Are there good guidelines for dealing with failures in the test harness
itself, rather than errors resulting from the actual thing being tested?
Or do we lump them all as "fail" and let the developers sort it out?