From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 45C633858400 for ; Wed, 10 Nov 2021 18:30:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 45C633858400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-Byop61QSNbG5lVbLXetPgg-1; Wed, 10 Nov 2021 13:30:41 -0500 X-MC-Unique: Byop61QSNbG5lVbLXetPgg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D79DE10151E0 for ; Wed, 10 Nov 2021 18:30:40 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-76.phx2.redhat.com [10.3.112.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9FDA5C3DF; Wed, 10 Nov 2021 18:30:40 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 1AAIUdLa2827739; Wed, 10 Nov 2021 13:30:39 -0500 From: DJ Delorie To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [patch v1] Allow for unpriviledged nested containers In-Reply-To: <87zgqc7724.fsf@oldenburg.str.redhat.com> Date: Wed, 10 Nov 2021 13:30:39 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 18:30:44 -0000 Florian Weimer writes: > Have you tried a bind mount of the existing /proc into the chroot (from > the outside of that chroot)? That's an interesting idea, but the directory it (and /sys, /dev, etc, eventually, I suppose) needs to be mounted on doesn't exist until we're late into "make check" and rsync'ing the pristine test container to the working test container. And we delete and rebuild that container as needed. It would be a lot of messy logic to pre-mount that. I talked with Carlos about this a bit and he suggested we could add a support_need_special_mounts() that just exits UNSUPPORTED if mounts like /proc are missing, for tests that rely on such. I'd rather not wait for that for this patch, though, as this patch at least enables more PASSing tests in the CICD stuff.