From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: RFC V2 [2/2] test-in-container
Date: Thu, 28 Jun 2018 21:05:00 -0000 [thread overview]
Message-ID: <xnlgayhbb5.fsf@greed.delorie.com> (raw)
In-Reply-To: <4678c750-7cd2-7867-dfd0-b2ae0d57f9e1@redhat.com> (message from Florian Weimer on Tue, 26 Jun 2018 15:02:54 +0200)
> I like this interface for writing tests, but it doesn't quite work at
> present: the makefile doesn't know about the test dependency on
> libnss_test1.so.2 and libnss_test2.so.2, so you get spurious failures
> at high concurrency levels.
This is supposed to handle it, in nss/Makefile already:
$(patsubst %,$(objpfx)%.out,$(tests)) : \
$(objpfx)/libnss_test1.so$(libnss_test1.so-version) \
$(objpfx)/libnss_test2.so$(libnss_test2.so-version)
> Should these instructions be included in the makefile instead?
Well, two reasons not to...
1. There are a lot of shortcuts in that "syntax" that would be more
complex in a plain Makefile. Reducing the cost of adding lots of
tests was one of the design considerations.
2. We run that script after we've locked and cleaned the testroot, which
we can't do in the Makefile.
prev parent reply other threads:[~2018-06-28 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 10:20 DJ Delorie
2018-06-26 13:03 ` Florian Weimer
2018-06-28 21:05 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnlgayhbb5.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).