public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org, carlos@redhat.com
Subject: Re: [swbz 29035] mktime vs non-DST
Date: Thu, 18 Aug 2022 18:40:06 -0400	[thread overview]
Message-ID: <xnmtc15g6x.fsf@greed.delorie.com> (raw)
In-Reply-To: <cad84eb9-70c8-0335-6b10-5ada66636dac@cs.ucla.edu>

Paul Eggert <eggert@cs.ucla.edu> writes:
> First, mktime is not "broken" if

Yeah, leftovers from the first iteration, and it just means that the
results don't match what the test expected.  We get to argue over what a
valid test is later ;-)

> illustrate why the differences between old glibc and Gnulib (a)
> largely don't matter,

Sadly, when someone has an application that's been expecting those
results for ages, and suddenly their code breaks, they don't care if the
new version is "better".  It's just "different".  You've given a few
examples of how mktime() might be abused, but we have no idea what kind
of abuses someone else's code might be relying on.

So while I agree that gnulib's code is more consistent, and thus better,
I'm still going to argue the other side until we've covered all the
options - for all those users who will still be affected by the "right"
change.


  reply	other threads:[~2022-08-18 22:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 21:18 DJ Delorie
2022-08-17 21:50 ` Carlos O'Donell
2022-08-17 23:10 ` Paul Eggert
2022-08-18  1:39   ` DJ Delorie
2022-08-18  2:37     ` Carlos O'Donell
2022-08-18  3:16       ` Paul Eggert
2022-08-18  4:05         ` Carlos O'Donell
2022-08-18 21:17       ` DJ Delorie
2022-08-18 21:57         ` Paul Eggert
2022-08-18 22:40           ` DJ Delorie [this message]
2022-08-18 22:58             ` Paul Eggert
2022-08-19 18:15               ` DJ Delorie
2022-08-19 22:04                 ` Paul Eggert
2022-08-18  3:02     ` Paul Eggert
2022-09-08 20:25   ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xnmtc15g6x.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=carlos@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).