From: DJ Delorie <dj@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org, john.ogness@linutronix.de
Subject: Re: [PATCH] mtrace: Fix output with PIE and ASLR [BZ #22716]
Date: Thu, 12 Aug 2021 00:15:23 -0400 [thread overview]
Message-ID: <xnmtpn5mec.fsf@greed.delorie.com> (raw)
In-Reply-To: <20210722132457.1945231-1-siddhesh@sourceware.org>
Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> writes:
LGTM with one note...
> - if (open (LOCS, "env LD_TRACE_LOADED_OBJECTS=1 $prog |")) {
> + if (open (LOCS, "env LD_TRACE_PRELINKING=1 $prog |")) {
Note that LD_TRACE_PRELINKING specifies a list of objects; setting it to
"1" works as long as none of the objects are named "1". I would think a
suitable comment would at least prevent spreading misunderstandings
about that variable.
Reviewed-by: DJ Delorie <dj@redhat.com>
next prev parent reply other threads:[~2021-08-12 4:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 13:24 Siddhesh Poyarekar
2021-07-22 14:12 ` John Ogness
2021-07-22 14:31 ` Siddhesh Poyarekar
2021-07-22 14:45 ` John Ogness
2021-07-22 15:17 ` Siddhesh Poyarekar
2021-07-22 15:19 ` Siddhesh Poyarekar
2021-08-11 7:41 ` [PING][PATCH] " Siddhesh Poyarekar
2021-08-12 4:15 ` DJ Delorie [this message]
2021-08-12 4:33 ` [PATCH] " Siddhesh Poyarekar
2021-08-12 4:35 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnmtpn5mec.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).