From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rhel8.vm.delorie.com (d-159-250-13-23.nh.cpe.atlanticbb.net [159.250.13.23]) by sourceware.org (Postfix) with ESMTPS id 6FCAE385800D for ; Fri, 5 Mar 2021 00:28:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FCAE385800D Received: from rhel8.vm.redhat.com (localhost [127.0.0.1]) by rhel8.vm.delorie.com (8.15.2/8.15.2) with ESMTPS id 1250SYT3036303 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 4 Mar 2021 19:28:35 -0500 From: DJ Delorie To: Szabolcs Nagy Cc: libc-alpha@sourceware.org, Richard.Earnshaw@arm.com Subject: Re: [PATCH 07/16] malloc: Refactor TAG_ macros to avoid indirection In-Reply-To: (message from Szabolcs Nagy on Thu, 4 Mar 2021 16:32:10 +0000) Date: Thu, 04 Mar 2021 19:28:34 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, KAM_DMARC_NONE, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, RDNS_DYNAMIC, SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 00:28:39 -0000 Szabolcs Nagy writes: > This does not change behaviour, just removes one layer of indirection > in the internal memory tagging logic. > > Use tag_ and mtag_ prefixes instead of __tag_ and __mtag_ since these > are all symbols with internal linkage, private to malloc.c, so there > is no user namespace pollution issue. > --- > malloc/arena.c | 16 +++++----- > malloc/hooks.c | 10 +++--- > malloc/malloc.c | 81 +++++++++++++++++++++++-------------------------- > 3 files changed, 51 insertions(+), 56 deletions(-) LGTM Reviewed-by: DJ Delorie