From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B1C753858C52 for ; Tue, 21 Mar 2023 21:48:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1C753858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679435327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=CylJChhAegGBTpTro6L8uLn/CDZ4DiL3c6sl3Pjob5g=; b=VmxW+bckZ8yXqlDFFm1mFJFQbmmEnhu+vhLPKa9w4zP+uV5hus/Y8g5LSELH2HTt7/rdSK kusbAb3b3DFZbJWorIREG+oX7SQ9yAWakr0czP22Ctzs3EqPfp37BYmAL2mW7eEI5LGS9q frsuVYrpb45JiQBVlmSV250M6dSnLvY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-rAEbB4VAO-qcF2KnorB_YQ-1; Tue, 21 Mar 2023 17:48:44 -0400 X-MC-Unique: rAEbB4VAO-qcF2KnorB_YQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC8C5280048A; Tue, 21 Mar 2023 21:48:43 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.8.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9625240C83A9; Tue, 21 Mar 2023 21:48:43 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 32LLmgh83839928; Tue, 21 Mar 2023 17:48:42 -0400 From: DJ Delorie To: MAHESH BODAPATI Cc: libc-alpha@sourceware.org, rajis@linux.ibm.com, skissane@gmail.com, mahesh.bodapati@ibm.com Subject: Re: [PATCH v2] Skip mcount overflow and tunables tests on "--disable-tunables" In-Reply-To: <20230321183350.2499793-1-bmahi496@linux.ibm.com> Date: Tue, 21 Mar 2023 17:48:42 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: MAHESH BODAPATI writes: > +have-tunables = @have_tunables@ config.make.in already has one of these. The rest looks OK, but did you test it with tunables disabled vs enabled? > diff --git a/gmon/Makefile b/gmon/Makefile > index 213622a7ad..934a2b230d 100644 > --- a/gmon/Makefile > +++ b/gmon/Makefile > @@ -26,7 +26,11 @@ include ../Makeconfig > headers := sys/gmon.h sys/gmon_out.h sys/profil.h > routines := gmon mcount profil sprofil prof-freq > > -tests = tst-sprofil tst-gmon tst-mcount-overflow tst-mcleanup > +tests = tst-sprofil tst-gmon tst-mcleanup > +ifeq ($(have-tunables),yes) > +tests += tst-mcount-overflow > +endif > + > ifeq ($(build-profile),yes) > tests += tst-profile-static > tests-static += tst-profile-static > @@ -57,6 +61,7 @@ ifeq ($(run-built-tests),yes) > tests-special += $(objpfx)tst-gmon-gprof.out > endif > > +ifeq ($(have-tunables),yes) > CFLAGS-tst-mcount-overflow.c := -fno-omit-frame-pointer -pg > tst-mcount-overflow-no-pie = yes > CRT-tst-mcount-overflow := $(csu-objpfx)g$(start-installed-name) > @@ -68,6 +73,7 @@ tst-mcount-overflow-ARGS := 2>&1 1>/dev/null | cat > ifeq ($(run-built-tests),yes) > tests-special += $(objpfx)tst-mcount-overflow-check.out > endif > +endif > > CFLAGS-tst-mcleanup.c := -fno-omit-frame-pointer -pg > tst-mcleanup-no-pie = yes > @@ -124,6 +130,7 @@ $(objpfx)tst-gmon.out: clean-tst-gmon-data > clean-tst-gmon-data: > rm -f $(objpfx)tst-gmon.data.* > > +ifeq ($(have-tunables),yes) > $(objpfx)tst-mcount-overflow.o: clean-tst-mcount-overflow-data > clean-tst-mcount-overflow-data: > rm -f $(objpfx)tst-mcount-overflow.data.* > @@ -131,6 +138,7 @@ clean-tst-mcount-overflow-data: > $(objpfx)tst-mcount-overflow-check.out: tst-mcount-overflow-check.sh $(objpfx)tst-mcount-overflow.out > $(SHELL) $< $(objpfx)tst-mcount-overflow > $@; \ > $(evaluate-test) > +endif > > $(objpfx)tst-mcleanup.out: clean-tst-mcleanup-data > clean-tst-mcleanup-data: