From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 19B28395200C for ; Thu, 17 Mar 2022 05:06:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19B28395200C Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-331-nK7-uAKNNHuqTfHn1K71jg-1; Thu, 17 Mar 2022 01:06:15 -0400 X-MC-Unique: nK7-uAKNNHuqTfHn1K71jg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15285296A60C; Thu, 17 Mar 2022 05:06:15 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-4.rdu2.redhat.com [10.10.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 019C540D2820; Thu, 17 Mar 2022 05:06:14 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 22H56Eq21745301; Thu, 17 Mar 2022 01:06:14 -0400 From: DJ Delorie To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 12/12] gethosts: Return EAI_MEMORY on allocation failure In-Reply-To: <20220314094835.1159523-13-siddhesh@sourceware.org> (message from Siddhesh Poyarekar via Libc-alpha on Mon, 14 Mar 2022 15:18:35 +0530) Date: Thu, 17 Mar 2022 01:06:14 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 05:06:20 -0000 Siddhesh Poyarekar via Libc-alpha writes: > All other cases of failures due to lack of memory return EAI_MEMORY, so > it seems wrong to return EAI_SYSTEM here. The only reason > convert_hostent_to_gaih_addrtuple could fail is on calloc failure. LGTM. Reviewed-by: DJ Delorie > diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c > index eebed824a8..5cd988bec5 100644 > --- a/sysdeps/posix/getaddrinfo.c > +++ b/sysdeps/posix/getaddrinfo.c > @@ -303,13 +303,13 @@ gethosts (nss_gethostbyname3_r fct, int family, const char *name, > else if (status == NSS_STATUS_SUCCESS) > { > if (!convert_hostent_to_gaih_addrtuple (req, family, &th, res)) > - return -EAI_SYSTEM; > + return -EAI_MEMORY; > > if (localcanon != NULL && res->canon == NULL) > { > char *canonbuf = __strdup (localcanon); > if (canonbuf == NULL) > - return -EAI_SYSTEM; > + return -EAI_MEMORY; > res->canon = canonbuf; > } > }