From: DJ Delorie <dj@redhat.com>
To: fweimer@redhat.com (Florian Weimer)
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] gethostid (Linux variant): Switch to struct scratch_buffer [BZ #18023]
Date: Tue, 26 Jun 2018 18:16:00 -0000 [thread overview]
Message-ID: <xnr2ktifbq.fsf@greed.delorie.com> (raw)
In-Reply-To: <20180626154633.BC8B943994575@oldenburg.str.redhat.com> (fweimer@redhat.com)
fweimer@redhat.com (Florian Weimer) writes:
> [BZ #18023]
> * sysdeps/unix/sysv/linux/gethostid.c (gethostid): Use struct
> scratch_buffer instead of extend_alloca. Update comments.
LGTM
A question about style, though... you have an if/else inside an else{}
block. Would it be more readable to do if {} elseif {} else {} instead?
prev parent reply other threads:[~2018-06-26 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 15:46 Florian Weimer
2018-06-26 16:58 ` Adhemerval Zanella
2018-06-26 17:33 ` Florian Weimer
2018-06-26 17:52 ` Adhemerval Zanella
2018-09-18 10:51 ` Andreas Schwab
2018-09-18 10:59 ` Florian Weimer
2018-09-18 12:09 ` Andreas Schwab
2018-09-18 12:32 ` Florian Weimer
2018-06-26 18:16 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnr2ktifbq.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).