From: DJ Delorie <dj@redhat.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [patch] nss: fix nss_database_lookup2's alternate handling [27416]
Date: Mon, 22 Feb 2021 20:16:02 -0500 [thread overview]
Message-ID: <xnsg5n60tp.fsf@greed.delorie.com> (raw)
In-Reply-To: <70e16944-6877-a308-d818-8d798b159037@redhat.com> (carlos@redhat.com)
"Carlos O'Donell" <carlos@redhat.com> writes:
> On 2/19/21 5:22 PM, DJ Delorie via Libc-alpha wrote:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=27416
>
> Could you please provide the full commit message you plan to
> use for this commit?
That was it. Is more required?
> If you commit your change locally then do:
> git format-patch HEAD~1
> git send-email mydiff.patch
I commit my change locally, use gitk to extract it, then mail it on a
different machine.
> Please repost v2.
What changes are required?
>> + else if (strcmp (p->pw_name, "name100") != 0)
>> + FAIL_EXIT1("getpwuid-compat-test1 name100");
>
> OK. Password uses compat which redirects to test1 instead of files.
> So seeing name100 means files was used and that's wrong.
"name100" comes from test1; we're testing that it *is* returned, which
means test1 *is* being used to back compat.
next prev parent reply other threads:[~2021-02-23 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 22:22 DJ Delorie
2021-02-20 16:19 ` Carlos O'Donell
2021-02-23 1:16 ` DJ Delorie [this message]
2021-02-23 4:06 ` Carlos O'Donell
2021-02-22 12:13 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnsg5n60tp.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).