From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B9E523858C54 for ; Tue, 28 Mar 2023 19:41:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9E523858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680032466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=IQ4q3S4Dv8rnDPeIkqFEPiBI09dhVxx6qYYYjHlkBQA=; b=IUe5GqH4SCdok6jP3nXxQue+WtGBRxURv68XIDEB8TwbKgE/A/na2AWzW9ksFKbJHHQ06A c6wHJBvzdG39LZFDjnCsjoJAfoh2SAyUFf1KdYgOqg9Gmqeth2wWtUl5LNndCvvx4SXzmK uXXvbpV3oAw5yhDZDXe8TE9eizqE4mk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-570-JFB4mLRtNyqCaYnalnZeJw-1; Tue, 28 Mar 2023 15:41:03 -0400 X-MC-Unique: JFB4mLRtNyqCaYnalnZeJw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A478228237C6; Tue, 28 Mar 2023 19:41:02 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.8.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90B49492C13; Tue, 28 Mar 2023 19:41:02 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 32SJf1fT018791; Tue, 28 Mar 2023 15:41:02 -0400 From: DJ Delorie To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Remove --disable-experimental-malloc option In-Reply-To: <20230328185015.2058355-1-adhemerval.zanella@linaro.org> Date: Tue, 28 Mar 2023 15:41:01 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Adhemerval Zanella writes: > -'--disable-experimental-malloc' > - By default, a per-thread cache is enabled in 'malloc'. While this > - cache can be disabled on a per-application basis using tunables > - (set glibc.malloc.tcache_count to zero), this option can be used to > - remove it from the build completely. > - Ok. Also, yay :-) > CPPFLAGS-malloc-debug.c += -DUSE_TCACHE=0 > -ifeq ($(experimental-malloc),yes) > CPPFLAGS-malloc.c += -DUSE_TCACHE=1 > -else > -CPPFLAGS-malloc.c += -DUSE_TCACHE=0 > -endif In the future, we could default this inside malloc.c instead of doing this in the Makefile, but it's not important now. Ok. > diff --git a/manual/install.texi b/manual/install.texi > index 260f8a5c82..cb76fbd28f 100644 > --- a/manual/install.texi > +++ b/manual/install.texi > @@ -292,12 +292,6 @@ This option is for hackers and distributions experimenting with > independently-maintained implementations of libcrypt. It may become > the default in a future release. > > -@item --disable-experimental-malloc > -By default, a per-thread cache is enabled in @code{malloc}. While > -this cache can be disabled on a per-application basis using tunables > -(set glibc.malloc.tcache_count to zero), this option can be used to > -remove it from the build completely. > - LGTM. Reviewed-by: DJ Delorie