From: DJ Delorie <dj@redhat.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: fweimer@redhat.com, libc-alpha@sourceware.org
Subject: Re: [PATCH] test-container: Add $complocaledir and mkdirp.
Date: Tue, 28 Apr 2020 20:12:51 -0400 [thread overview]
Message-ID: <xntv1387zw.fsf@greed.delorie.com> (raw)
In-Reply-To: <dfcd6c57-9117-6000-dbd4-ae6c154ba4eb@redhat.com> (carlos@redhat.com)
"Carlos O'Donell" <carlos@redhat.com> writes:
> I've already tested and created $complocaledir and mkdirp, should we just
> add them as additional functionality others would find useful?
Sure.
> Basically my thought is "Yes." because at the end of the day the tests
> will all want access to every configured directory we install things
> into, and mkdirp seems useful for scripts.
Yup. The goal of a testing toolkit is to provide a set of primitive
features that enable the fastest development of tests, so that
developers have no excuse to not write tests. Making makefile variables
available to those primitives, and expanding those primitives, adds to
that goal.
next prev parent reply other threads:[~2020-04-29 0:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 19:17 Carlos O'Donell
2020-04-27 7:49 ` Florian Weimer
2020-04-28 19:59 ` Carlos O'Donell
2020-04-28 22:03 ` DJ Delorie
2020-04-28 23:44 ` Carlos O'Donell
2020-04-29 0:12 ` DJ Delorie [this message]
2020-04-28 18:09 ` DJ Delorie
2020-04-29 15:55 ` [PATCH v2] test-container: Support $(complocaledir) " Carlos O'Donell
2020-04-29 17:57 ` DJ Delorie
2020-04-29 21:31 ` [PATCH v3] " Carlos O'Donell
2020-04-29 22:57 ` DJ Delorie
2020-04-30 20:29 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xntv1387zw.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).