From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 63971385DC0A for ; Wed, 29 Apr 2020 00:12:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 63971385DC0A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-6aA3_fIBPaOxnqv1p2uG5A-1; Tue, 28 Apr 2020 20:12:55 -0400 X-MC-Unique: 6aA3_fIBPaOxnqv1p2uG5A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3DED800C78 for ; Wed, 29 Apr 2020 00:12:54 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-52.phx2.redhat.com [10.3.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6F0B600D2; Wed, 29 Apr 2020 00:12:52 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id 03T0Cpbw032497; Tue, 28 Apr 2020 20:12:51 -0400 From: DJ Delorie To: "Carlos O'Donell" Cc: fweimer@redhat.com, libc-alpha@sourceware.org Subject: Re: [PATCH] test-container: Add $complocaledir and mkdirp. In-Reply-To: (carlos@redhat.com) Date: Tue, 28 Apr 2020 20:12:51 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 00:13:00 -0000 "Carlos O'Donell" writes: > I've already tested and created $complocaledir and mkdirp, should we just > add them as additional functionality others would find useful? Sure. > Basically my thought is "Yes." because at the end of the day the tests > will all want access to every configured directory we install things > into, and mkdirp seems useful for scripts. Yup. The goal of a testing toolkit is to provide a set of primitive features that enable the fastest development of tests, so that developers have no excuse to not write tests. Making makefile variables available to those primitives, and expanding those primitives, adds to that goal.