From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 6C71B3858D3C for ; Thu, 5 Aug 2021 18:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C71B3858D3C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-6rdc_75ROnGJZOTnx1_s8g-1; Thu, 05 Aug 2021 14:10:06 -0400 X-MC-Unique: 6rdc_75ROnGJZOTnx1_s8g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E19B2190A7A1; Thu, 5 Aug 2021 18:10:05 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-6.rdu2.redhat.com [10.10.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF66360E1C; Thu, 5 Aug 2021 18:10:05 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 175IA4c51060923; Thu, 5 Aug 2021 14:10:04 -0400 From: DJ Delorie To: Paul Eggert Cc: libc-alpha@sourceware.org Subject: Re: glob vs '*/' vs GLOB_ONLYDIR vs xfs In-Reply-To: Date: Thu, 05 Aug 2021 14:10:04 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 18:10:09 -0000 Paul Eggert writes: > Isn't that a bug in XFS? readdir should set d_type to DT_UNKNOWN if it > doesn't know the type. It shouldn't set d_type to garbage. XFS sets d_type to DT_UNKNOWN for most entries, not garbage. > Doesn't glob do the right thing if d_type is DT_UNKNOWN? No, if by "right thing" you mean "call lstat and find out the right type".