public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org
Subject: Re: v5 [PATCH 6/6] nsswitch: use new internal API (callers)
Date: Wed, 17 Feb 2021 23:55:29 -0500	[thread overview]
Message-ID: <xnv9aq6kla.fsf@greed.delorie.com> (raw)
In-Reply-To: <878s7mjn2p.fsf@igel.home> (message from Andreas Schwab on Thu, 18 Feb 2021 00:23:26 +0100)

Andreas Schwab <schwab@linux-m68k.org> writes:
>>> On Feb 17 2021, DJ Delorie wrote:
>>>> If you're refering to the "Neither found" comment, it reaches that if
>>>> nsswitch.conf mentions neither the primary nor alternate service name.
>>>
>>> Does it?  How so?
>>
>> Er... we just tested for them?
>>
>>       /* If *NI is NULL, the database was not mentioned in nsswitch.conf.
>>          If *NI is not NULL, but *NI->module is NULL, the database was in
>>          nsswitch.conf but listed no actions.  We test for the former.  */
>
> Why do you think that comment is accurate?

I'm going to go with "because I wrote it" even though that sounds a bit
conceited.  I'll add "and it passed review" for bonus point.  And to
anticipate your next one-line response, "by reading the code".  And
after your reponse to that, "why don't you just tell me what you think
the solution is?" because these conversations take forever when you
don't explain yourself or include enough information for us to know what
you're thinking.

Please refer to the bottom of
https://sourceware.org/glibc/wiki/FilingBugs for a reminder about what
we like to see in bug reports.  A reproducer would have been nice.
Especially if it were in the form of an in-tree test case that
demonstrates the problem.


  reply	other threads:[~2021-02-18  4:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 20:34 DJ Delorie
2020-12-04  3:29 ` Siddhesh Poyarekar
2021-02-15 15:42   ` Andreas Schwab
2021-02-16  2:36     ` DJ Delorie
2021-02-16  8:38       ` Andreas Schwab
2021-02-17  5:42         ` DJ Delorie
2021-02-17 13:27           ` Andreas Schwab
2021-02-17 20:44             ` DJ Delorie
2021-02-17 21:09               ` Andreas Schwab
2021-02-17 21:15                 ` DJ Delorie
2021-02-17 22:31                   ` Andreas Schwab
2021-02-17 22:51                     ` DJ Delorie
2021-02-17 23:23                       ` Andreas Schwab
2021-02-18  4:55                         ` DJ Delorie [this message]
2021-02-18  8:43                           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xnv9aq6kla.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).