From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A0F79385800A for ; Thu, 18 Feb 2021 04:55:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A0F79385800A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-R3LWey2VM1SCWxuaimNo9Q-1; Wed, 17 Feb 2021 23:55:32 -0500 X-MC-Unique: R3LWey2VM1SCWxuaimNo9Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84B7A9126D; Thu, 18 Feb 2021 04:55:31 +0000 (UTC) Received: from greed.delorie.com (ovpn-116-4.rdu2.redhat.com [10.10.116.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5514719C46; Thu, 18 Feb 2021 04:55:31 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id 11I4tTlC014990; Wed, 17 Feb 2021 23:55:29 -0500 From: DJ Delorie To: Andreas Schwab Cc: libc-alpha@sourceware.org Subject: Re: v5 [PATCH 6/6] nsswitch: use new internal API (callers) In-Reply-To: <878s7mjn2p.fsf@igel.home> (message from Andreas Schwab on Thu, 18 Feb 2021 00:23:26 +0100) Date: Wed, 17 Feb 2021 23:55:29 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 04:55:37 -0000 Andreas Schwab writes: >>> On Feb 17 2021, DJ Delorie wrote: >>>> If you're refering to the "Neither found" comment, it reaches that if >>>> nsswitch.conf mentions neither the primary nor alternate service name. >>> >>> Does it? How so? >> >> Er... we just tested for them? >> >> /* If *NI is NULL, the database was not mentioned in nsswitch.conf. >> If *NI is not NULL, but *NI->module is NULL, the database was in >> nsswitch.conf but listed no actions. We test for the former. */ > > Why do you think that comment is accurate? I'm going to go with "because I wrote it" even though that sounds a bit conceited. I'll add "and it passed review" for bonus point. And to anticipate your next one-line response, "by reading the code". And after your reponse to that, "why don't you just tell me what you think the solution is?" because these conversations take forever when you don't explain yourself or include enough information for us to know what you're thinking. Please refer to the bottom of https://sourceware.org/glibc/wiki/FilingBugs for a reminder about what we like to see in bug reports. A reproducer would have been nice. Especially if it were in the form of an in-tree test case that demonstrates the problem.