From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C950B3858C5F for ; Tue, 12 Mar 2024 02:37:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C950B3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C950B3858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710211040; cv=none; b=dA2vkV5n2FZkUlJoU77EuZuPLgmfBM/PN7J+RZn83ZOT0Jq3uTUPMY+QyX06JRqTB0TgJ8yC8ywwr1aicMd+iV3K0jvdiYBoeRe5HJE6/VsCJAYyv5Xsqf5lyqzooBWJmvjk5e9Rs2yFnjH/jMoWfwdELTfel19jkwqyGzQeTvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710211040; c=relaxed/simple; bh=yp1RURAdahBekRFx102t+0VV2LqjGZ9qdML3bq3rs80=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LpZVhZxYjeS2xjRC3gI6hmSAaSxbCzFalxvfO3bOP080hcK3WggmbSpBQMVZCJFASWNOBFjJk1kMjEurLrUld7i7NKvdp2B76NiJs+2n+jrkbSKIxde0uxbmxqs5gVB0lZE1UtsRIOSOq8qkvw5OLiUMhhhiEeSrPo3muRyoDJE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710211038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=1H/FNlJlm41uY0U98SGPH1TCA+1EDXh3lGdniefWkvg=; b=Zx6eZDMOIyeiwXCqEXFXUJ1dg2QtVrp1dBuu6ms1SGxIurEbLUFfwx6FSHIzLeN4+pscfz Mv5m11x5UjEEc20Bcn/tKz3wuC+8nLmG80xS+D6SLrtLQoT0vCBuill9If6b2ITax1/4jP i1XH4MncmacGRImja86GcV8A2S2NdFA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-6qIu6tUlPeC5H9wMpsAB5w-1; Mon, 11 Mar 2024 22:37:16 -0400 X-MC-Unique: 6qIu6tUlPeC5H9wMpsAB5w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F991383E131; Tue, 12 Mar 2024 02:37:16 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.8.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 334052166B4F; Tue, 12 Mar 2024 02:37:16 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 42C2bFhp2825789; Mon, 11 Mar 2024 22:37:15 -0400 From: DJ Delorie To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, bergner@linux.ibm.com Subject: Re: [PATCH] powerpc: Remove power8 strcasestr optimization In-Reply-To: <20240305201348.2470552-1-adhemerval.zanella@linaro.org> Date: Mon, 11 Mar 2024 22:37:15 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TVD_SUBJ_WIPE_DEBT,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Adhemerval Zanella writes: > diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile > - strlen-power8 strcasestr-power8 strcasestr-ppc64 \ > + strlen-power8 \ Removing strcasestr-power8 and strcasestr-ppc64, ok. > diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c > index e3e6f5fd10..30fd89e109 100644 > --- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c > +++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c > @@ -432,14 +432,5 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > IFUNC_IMPL_ADD (array, i, strcspn, 1, > __strcspn_ppc)) > > - /* Support sysdeps/powerpc/powerpc64/multiarch/strcasestr.c. */ > - IFUNC_IMPL (i, name, strcasestr, > - IFUNC_IMPL_ADD (array, i, strcasestr, > - hwcap2 & PPC_FEATURE2_ARCH_2_07 > - && hwcap & PPC_FEATURE_HAS_ALTIVEC, > - __strcasestr_power8) > - IFUNC_IMPL_ADD (array, i, strcasestr, 1, > - __strcasestr_ppc)) > - We're removing all of the three implementations, so ok. > diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S > deleted file mode 100644 > diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c > deleted file mode 100644 > diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr.c b/sysdeps/powerpc/powerpc64/multiarch/strcasestr.c > deleted file mode 100644 Ok. > diff --git a/sysdeps/powerpc/powerpc64/power8/Makefile b/sysdeps/powerpc/powerpc64/power8/Makefile > deleted file mode 100644 > diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr-ppc64.c b/sysdeps/powerpc/powerpc64/power8/strcasestr-ppc64.c > deleted file mode 100644 > diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr.S b/sysdeps/powerpc/powerpc64/power8/strcasestr.S > deleted file mode 100644 Ok. LGTM Reviewed-by: DJ Delorie