From: DJ Delorie <dj@redhat.com>
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Add strlcpy/wcslcpy testcase
Date: Thu, 27 Jul 2023 15:20:29 -0400 [thread overview]
Message-ID: <xnwmylqhz6.fsf@greed.delorie.com> (raw)
In-Reply-To: <CAMAf5_f8AXv59r96yh2BwRZD17c3EX=6rwScuEXo7J=Y23dc2Q@mail.gmail.com> (message from Sunil Pandey on Thu, 27 Jul 2023 12:10:18 -0700)
Sunil Pandey <skpgkp2@gmail.com> writes:
> Actually, it's already testing the generic version of strlcpy
> implementation from the string/strlcpy.c file, so no need to implement
> another SIMPLE_* function.
While that is true at the moment, in the future someone will start
optimizing that function, add cpu-family-specific variants, etc. Then,
when you're running on some core that chooses a vector-optimized
strlcpy, the simple function will be useful.
Note: I'm not saying "you must add this" as most of the other tests
don't either, and some test is better than no test. I just don't want
you to make a decision based on me not explaining myself well enough ;-)
The easy path would have been to just add the IMPL line and have that
extra level of paranoia built-in from the start.
next prev parent reply other threads:[~2023-07-27 19:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 20:45 Sunil K Pandey
2023-07-15 1:07 ` DJ Delorie
2023-07-17 18:50 ` Carlos O'Donell
2023-07-17 20:48 ` DJ Delorie
2023-07-27 17:51 ` [PATCH v2] " Sunil K Pandey
2023-07-27 17:55 ` [PATCH] " Sunil Pandey
2023-07-27 18:50 ` DJ Delorie
2023-07-27 19:10 ` Sunil Pandey
2023-07-27 19:20 ` DJ Delorie [this message]
2023-07-27 20:25 ` Sunil Pandey
2023-07-27 23:20 ` [PATCH v3] " Sunil K Pandey
2023-10-17 22:23 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnwmylqhz6.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).