From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 443443858D33 for ; Wed, 22 Feb 2023 22:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 443443858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677103533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=vw3P2aJgyjoqEMgL8Ud2sbeogNMPdz03VykOZ4e6yLM=; b=Mlrnyj2TZp+gpX8S6b1ljFwYC9/4SatYxVkDVJ2ijKnrXW9jYvTQsVLcRcQmQom8TaFOlw g2DakhHXL3ozZFOdoAezEPlz7YOmBRK9Gz6iTvOdMpWGaluSFB/PwMaUJ2perzJyjOom5H wa3hSb0VcogKrKbf47K698D/oZvEkhM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-QSED_W2_N826YHfr9pKsVw-1; Wed, 22 Feb 2023 17:05:30 -0500 X-MC-Unique: QSED_W2_N826YHfr9pKsVw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4EE6729A9CA2; Wed, 22 Feb 2023 22:05:30 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.8.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3112F2166B29; Wed, 22 Feb 2023 22:05:30 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 31MM59Sc962609; Wed, 22 Feb 2023 17:05:29 -0500 From: DJ Delorie To: Ayush Mittal Cc: libc-alpha@sourceware.org, maninder1.s@samsung.com, a.sahrawat@samsung.com, akhilesh.k@samsung.com, ayush.m@samsung.com Subject: Re: [PATCH 1/1] malloc: remove redundant check of unsorted bin corruption In-Reply-To: <1617874149-11830-1-git-send-email-ayush.m@samsung.com> Date: Wed, 22 Feb 2023 17:05:09 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ayush Mittal via Libc-alpha writes: > * malloc/malloc.c (_int_malloc): remove redundant check of > unsorted bin corruption > > With commit "b90ddd08f6dd688e651df9ee89ca3a69ff88cd0c" > (malloc: Additional checks for unsorted bin integrity), > same check of (bck->fd != victim) is added before checking of unsorted > chunk corruption, which was added in "bdc3009b8ff0effdbbfb05eb6b10966753cbf9b8" > (Added check before removing from unsorted list). Sorry this one fell through the cracks. LGTM. Pushed. Reviewed-by: DJ Delorie