From: DJ Delorie <dj@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] support: Free gdb_script_name
Date: Wed, 12 May 2021 15:27:39 -0400 [thread overview]
Message-ID: <xnwns3zr9w.fsf@rhel8.vm> (raw)
In-Reply-To: <20210512043704.443470-1-siddhesh@sourceware.org>
Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> writes:
> Identified by static analysis.
> ---
> support/support_test_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/support/support_test_main.c b/support/support_test_main.c
> index cb72512226..07e3cdd173 100644
> --- a/support/support_test_main.c
> +++ b/support/support_test_main.c
> @@ -221,6 +221,7 @@ run_test_function (int argc, char **argv, const struct test_config *config)
> fprintf (gdb_script, "attach %ld\n", (long int) mypid);
> fprintf (gdb_script, "set wait_for_debugger = 0\n");
> fclose (gdb_script);
> + free (gdb_script_name);
> }
>
> /* Wait for the debugger to set wait_for_debugger to zero. */
LGTM.
Reviewed-by: DJ Delorie <dj@redhat.com>
prev parent reply other threads:[~2021-05-12 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 4:37 Siddhesh Poyarekar
2021-05-12 19:27 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnwns3zr9w.fsf@rhel8.vm \
--to=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).