From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D85C83853801 for ; Wed, 12 May 2021 19:27:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D85C83853801 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-HSv37RAGOZCu6zvYkTSYdA-1; Wed, 12 May 2021 15:27:41 -0400 X-MC-Unique: HSv37RAGOZCu6zvYkTSYdA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C36B980ED8D; Wed, 12 May 2021 19:27:40 +0000 (UTC) Received: from rhel8.vm.delorie.com (ovpn-119-18.rdu2.redhat.com [10.10.119.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CA726D8C5; Wed, 12 May 2021 19:27:40 +0000 (UTC) Received: from rhel8.vm.redhat.com (localhost [127.0.0.1]) by rhel8.vm.delorie.com (8.15.2/8.15.2) with ESMTP id 14CJRdJV1871589; Wed, 12 May 2021 15:27:39 -0400 From: DJ Delorie To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] support: Free gdb_script_name In-Reply-To: <20210512043704.443470-1-siddhesh@sourceware.org> Date: Wed, 12 May 2021 15:27:39 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2021 19:27:45 -0000 Siddhesh Poyarekar via Libc-alpha writes: > Identified by static analysis. > --- > support/support_test_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/support/support_test_main.c b/support/support_test_main.c > index cb72512226..07e3cdd173 100644 > --- a/support/support_test_main.c > +++ b/support/support_test_main.c > @@ -221,6 +221,7 @@ run_test_function (int argc, char **argv, const struct test_config *config) > fprintf (gdb_script, "attach %ld\n", (long int) mypid); > fprintf (gdb_script, "set wait_for_debugger = 0\n"); > fclose (gdb_script); > + free (gdb_script_name); > } > > /* Wait for the debugger to set wait_for_debugger to zero. */ LGTM. Reviewed-by: DJ Delorie