From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dj@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id D12E6398407F
 for <libc-alpha@sourceware.org>; Thu,  5 Aug 2021 03:24:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D12E6398407F
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-511-VFr3UWWRNSGIMHT9oqVuMQ-1; Wed, 04 Aug 2021 23:24:34 -0400
X-MC-Unique: VFr3UWWRNSGIMHT9oqVuMQ-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5248D107ACF5
 for <libc-alpha@sourceware.org>; Thu,  5 Aug 2021 03:24:33 +0000 (UTC)
Received: from greed.delorie.com (ovpn-112-6.rdu2.redhat.com [10.10.112.6])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 21BA960BF4
 for <libc-alpha@sourceware.org>; Thu,  5 Aug 2021 03:24:33 +0000 (UTC)
Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1])
 by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 1753OWIJ1052186
 for <libc-alpha@sourceware.org>; Wed, 4 Aug 2021 23:24:32 -0400
Date: Wed, 04 Aug 2021 23:24:32 -0400
Message-Id: <xny29go9ov.fsf@greed.delorie.com>
From: DJ Delorie <dj@redhat.com>
To: libc-alpha@sourceware.org
Subject: glob vs '*/' vs GLOB_ONLYDIR vs xfs
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="US-ASCII"
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Aug 2021 03:24:37 -0000


in posix/glob.c we have this comment:

  /* POSIX requires all slashes to be matched.  This means that with
     a trailing slash we must match only directories.  */
  if (pattern[0] && pattern[strlen (pattern) - 1] == '/')
    flags |= GLOB_ONLYDIR;

In "man glob" we see:

       GLOB_ONLYDIR
              This is a _hint_ to glob() that the caller is interested
              only in directories that match the pattern.

So, for starters, we're relying on "a hint" to implement a "must".

If you're running glob on an XFS filesystem, readdir() doesn't
reliably fill in d_type, and the "hint" fails:

#include <stdlib.h>
#include <glob.h>

main(int argc, char **argv) {
  glob_t g;
  int i;

  glob (argv[1], 0, NULL, &g);
  for (i=0; i<g.gl_pathc; i++)
    printf("glob[%d] = `%s'\n", i, g.gl_pathv[i]);

  return 0;
}

$ ls -l
total 4
-rw-r--r-- 1 dj games 56 Aug  4 22:45 Makefile
drwxr-xr-x 2 dj games 10 Aug  4 22:44 hellod/
-rw-r--r-- 1 dj games  0 Aug  4 22:44 hellof

$ pwd
/greed/dj/gnu/make-4.3/dj

$ ~/src/globtest 'hello*/'
glob[0] = `hellod/'
glob[1] = `hellof'

$ ~/src/globtest 'hello*'
glob[0] = `hellod'
glob[1] = `hellof'


If we instead run this on a different filesystem type (tmpfs in this
case), it works as I expect:

$ ls -l
total 4
-rw-r--r-- 1 dj games 56 Aug  4 22:45 Makefile
drwxr-xr-x 2 dj games  6 Aug  4 22:44 hellod/
-rw-r--r-- 1 dj games  0 Aug  4 22:44 hellof

$ pwd
/tmp/make-4.3/dj

$ ~/src/globtest 'hello*/'
glob[0] = `hellod/'

$ ~/src/globtest 'hello*'
glob[0] = `hellod'
glob[1] = `hellof'


Is this a bug in glob(), or a misunderstanding of its documentation?