From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128033 invoked by alias); 22 Jul 2019 20:56:25 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128020 invoked by uid 89); 22 Jul 2019 20:56:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=installation X-HELO: mx1.redhat.com From: DJ Delorie To: Tulio Magno Quites Machado Filho Cc: fweimer@redhat.com, libc-alpha@sourceware.org Subject: Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794] In-Reply-To: <20190722204533.21535-1-tuliom@linux.ibm.com> (message from Tulio Magno Quites Machado Filho on Mon, 22 Jul 2019 17:45:33 -0300) Date: Mon, 22 Jul 2019 20:56:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00516.txt.bz2 Tulio Magno Quites Machado Filho writes: > Whenever a sub-make is created, it inherits the variable subdirs from its > parent. This is also true when make check is called with a restricted > list of subdirs. In this scenario, make install is executed "partially" > and testroot.pristine ends up with an incomplete installation. "obvious in retrospect" Sigh. > 2019-07-22 Tulio Magno Quites Machado Filho > > [BZ #24794] > * Makefile (testroot.pristine/install.stamp): Pass > subdirs='$(all-subdirs)' to make install. LGTM. Thanks! Reviewed-by: DJ Delorie