From: DJ Delorie <dj@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v4 2/2] wcsmbs: Ensure wcstr worst-case linear execution time (BZ 23865)
Date: Wed, 10 Apr 2024 19:20:57 -0400 [thread overview]
Message-ID: <xnzfu03iue.fsf@greed.delorie.com> (raw)
In-Reply-To: <20240319131528.3222248-3-adhemerval.zanella@linaro.org> (message from Adhemerval Zanella on Tue, 19 Mar 2024 10:15:28 -0300)
I diff'd this with the older ones, and the only difference was the
removal of the loops. It still doesn't test for the time aspect of this
change, but it a least tests for the needle cases. I still think a true
time-based test is needed, but I don't think we'll be getting one soon,
and I won't hold up the rest of the patch for one.
Sorry for the delay.
LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>
prev parent reply other threads:[~2024-04-10 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 13:15 [PATCH v4 0/2] Improve wcsstr Adhemerval Zanella
2024-03-19 13:15 ` [PATCH v4 1/2] wcsmbs: Add test-wcsstr Adhemerval Zanella
2024-03-19 13:15 ` [PATCH v4 2/2] wcsmbs: Ensure wcstr worst-case linear execution time (BZ 23865) Adhemerval Zanella
2024-04-10 23:20 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnzfu03iue.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).