From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31957 invoked by alias); 13 Mar 2002 23:13:38 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 31899 invoked from network); 13 Mar 2002 23:13:34 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 13 Mar 2002 23:13:34 -0000 Received: from myware.mynet (fiendish.cygnus.com [205.180.231.146]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA18421; Wed, 13 Mar 2002 15:13:33 -0800 (PST) Received: from myware.mynet (myware.mynet [192.168.7.70]) by myware.mynet (8.11.6/8.11.6) with ESMTP id g2DNDW919345; Wed, 13 Mar 2002 15:13:32 -0800 Subject: Re: [PATCH] Fix _itoa_lower_digits (was Re: bootstrap 2.95 libc not building on alpha) From: Ulrich Drepper To: Jakub Jelinek Cc: Matthew Bemis , libc-hacker@sources.redhat.com In-Reply-To: <20020313173619.A2204@sunsite.ms.mff.cuni.cz> References: <3C8F6C22.6B38A19E@iol.unh.edu> <20020313173619.A2204@sunsite.ms.mff.cuni.cz> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-ctP13a54avNbdBwcn2HD" X-Mailer: Evolution/1.0.2 (1.0.2-0.7x) Date: Wed, 13 Mar 2002 15:13:00 -0000 Message-Id: <1016061212.6837.1083.camel@myware.mynet> Mime-Version: 1.0 X-SW-Source: 2002-03/txt/msg00046.txt.bz2 --=-ctP13a54avNbdBwcn2HD Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1381 On Wed, 2002-03-13 at 08:36, Jakub Jelinek wrote: > I think we should use _itoa_lower_digits_internal to avoid confusion. > The above error is because rtld.c used stdio-common/_itoa.h while > dl-reloc.c and dl-minimal.c used/defined _itoa_lower_digits explicitely. This shouldn't be necessary but so be it. I've applied the patch. > BTW: It is wrong that mp_clz_tab.c is "Not needed anywhere", Because I haven't looked everywhere I haven't removed the file. > it is > just not needed anywhere on certain arches. I'd think the best thing to do > would be to put them back, make __clz_tab hidden (but am not sure if > it should be in stdlib/longlong.h header (as e.g. gcc is not interested in > such changes), The file is not going back for all archs. Any change will have to happen in an architecture-dependent Makefile. How the attribute is added is another problem. Platforms oher than x86 are really not optimized in the moment so there is no need for such an isolated attempt at this time. Once I'm through I'll look at ia64 and alpha but all the rest remains for others. A lot of the optimizations are generic but still there is work to do. --=20 ---------------. ,-. 1325 Chesapeake Terrace Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA Red Hat `--' drepper at redhat.com `------------------------ --=-ctP13a54avNbdBwcn2HD Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 232 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQA8j90c2ijCOnn/RHQRAnMnAJ9BT/Peq1YXivEClF/QTQ3ngKdRHACfbITb isC4KevmH04eaCTO15kEMas= =t83g -----END PGP SIGNATURE----- --=-ctP13a54avNbdBwcn2HD--