public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* Fix Handling of visibility attribute with older gccs
@ 2002-03-16 11:57 Andreas Jaeger
  2002-03-16 13:43 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Jaeger @ 2002-03-16 11:57 UTC (permalink / raw)
  To: GNU libc hacker


With GCC 2.95.3 I get these warnings when compiling glibc from CVS:
itoa-digits.c:23: warning: `visibility' attribute directive ignored

Ok to commit the appended patch?

Andreas

2002-03-16  Andreas Jaeger  <aj@suse.de>

	* include/libc-symbols.h (_INTVARDEF): Define variant when
	visibility attribute is not supported.

============================================================
Index: include/libc-symbols.h
--- include/libc-symbols.h	2002/03/14 00:46:29	1.32
+++ include/libc-symbols.h	2002/03/16 19:53:40
@@ -362,9 +362,14 @@
 # define INTDEF(name) strong_alias (name, name##_internal)
 # define INTVARDEF(name) \
   _INTVARDEF (name, name##_internal)
-# define _INTVARDEF(name, aliasname) \
+# if defined HAVE_VISIBILITY_ATTRIBUTE
+#  define _INTVARDEF(name, aliasname) \
   extern __typeof (name) aliasname __attribute__ ((alias (#name), \
 						   visibility ("hidden")));
+# else
+#  define _INTVARDEF(name, aliasname) \
+  extern __typeof (name) aliasname __attribute__ ((alias (#name)));
+# endif
 # define INTDEF2(name, newname) strong_alias (name, newname##_internal)
 # define INTVARDEF2(name, newname) _INTVARDEF (name, newname##_internal)
 #else

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix Handling of visibility attribute with older gccs
  2002-03-16 11:57 Fix Handling of visibility attribute with older gccs Andreas Jaeger
@ 2002-03-16 13:43 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2002-03-16 13:43 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hacker

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Sat, 2002-03-16 at 11:57, Andreas Jaeger wrote:

> Ok to commit the appended patch?

Yes.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-03-16 21:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-16 11:57 Fix Handling of visibility attribute with older gccs Andreas Jaeger
2002-03-16 13:43 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).