* [PATCH] Don't die on unknown dynamic tags
@ 2002-03-30 10:02 Jakub Jelinek
2002-04-02 16:29 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2002-03-30 10:02 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Glibc hackers
Hi!
It seems like some distributions ship glibc not compiled with -DNDEBUG,
and as there is an assert on unknown dynamic tags, statically linked
programs against such glibc which do dlopen/nss die on any prelinked
libraries or libraries with some other dynamic tags not known to
such older glibc. IMHO glibc just shouldn't worry about dynamic tags
it knows nothing about, otherwise we are stuck with current set of dynamic
tags and cannot add a new one ever.
2002-03-30 Jakub Jelinek <jakub@redhat.com>
* elf/dynamic-link.h (elf_get_dynamic_info): Don't abort on unknown
dynamic tags.
--- libc/elf/dynamic-link.h.jj Fri Feb 8 12:04:02 2002
+++ libc/elf/dynamic-link.h Sat Mar 30 19:02:50 2002
@@ -59,8 +59,6 @@ elf_get_dynamic_info (struct link_map *l
else if ((Elf32_Word) DT_ADDRTAGIDX (dyn->d_tag) < DT_ADDRNUM)
info[DT_ADDRTAGIDX (dyn->d_tag) + DT_NUM + DT_THISPROCNUM
+ DT_VERSIONTAGNUM + DT_EXTRANUM + DT_VALNUM] = dyn;
- else
- assert (! "bad dynamic tag");
++dyn;
}
#ifndef DL_RO_DYN_SECTION
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Don't die on unknown dynamic tags
2002-03-30 10:02 [PATCH] Don't die on unknown dynamic tags Jakub Jelinek
@ 2002-04-02 16:29 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2002-04-02 16:29 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Sat, 2002-03-30 at 10:02, Jakub Jelinek wrote:
>
> 2002-03-30 Jakub Jelinek <jakub@redhat.com>
>
> * elf/dynamic-link.h (elf_get_dynamic_info): Don't abort on unknown
> dynamic tags.
OK, I've applied the patch. Thanks,
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-04-03 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-30 10:02 [PATCH] Don't die on unknown dynamic tags Jakub Jelinek
2002-04-02 16:29 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).