public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Generate unwind info for pthread_sighandler*
@ 2002-05-02  7:55 Jakub Jelinek
  2002-05-03  0:39 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2002-05-02  7:55 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: Glibc hackers

Hi!

I think one should be able to unwind through the pthread
signal handler wrappers (e.g. libjava currently uses very ugly workarounds
because of this).
Or would you prefer instead moving those 2 functions into separate source
file and add exceptions just to that file?

2002-05-02  Jakub Jelinek  <jakub@redhat.com>

	* Makefile (CFLAGS-signals.c): Build unwind info.

--- linuxthreads/Makefile.jj	Wed Jan 30 18:01:24 2002
+++ linuxthreads/Makefile	Thu May  2 16:57:10 2002
@@ -80,6 +80,7 @@ CFLAGS-pthread.c += -D__NO_WEAK_PTHREAD_
 CFLAGS-ptfork.c += -D__NO_WEAK_PTHREAD_ALIASES
 CFLAGS-cancel.c += -D__NO_WEAK_PTHREAD_ALIASES -D_RPC_THREAD_SAFE_
 CFLAGS-unload.c += -DPREFIX=\"$(objpfx)\"
+CFLAGS-signals.c += $(exceptions)
 
 # Depend on libc.so so a DT_NEEDED is generated in the shared objects.
 # This ensures they will load libc.so for needed symbols if loaded by

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Generate unwind info for pthread_sighandler*
  2002-05-02  7:55 [PATCH] Generate unwind info for pthread_sighandler* Jakub Jelinek
@ 2002-05-03  0:39 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2002-05-03  0:39 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Glibc hackers

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

On Thu, 2002-05-02 at 07:55, Jakub Jelinek wrote:

> Or would you prefer instead moving those 2 functions into separate source
> file and add exceptions just to that file?
>

I certainly prefer this.  The patch I checked in should do it.

But for the records: throwing exceptions from signal handlers wwas never
tested nor was it part of the "design".  If it works it's accidental. 
If it doesn't work that the reality to work with.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-05-03  7:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-02  7:55 [PATCH] Generate unwind info for pthread_sighandler* Jakub Jelinek
2002-05-03  0:39 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).