From: Ulrich Drepper <drepper@redhat.com>
To: Andreas Jaeger <aj@suse.de>
Cc: GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Re: fix .../linux/errlist.c
Date: Sun, 19 May 2002 23:41:00 -0000 [thread overview]
Message-ID: <1021876858.28991.167.camel@myware.mynet> (raw)
In-Reply-To: <u8u1p4gkk0.fsf@gromit.moeb>
[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]
On Sun, 2002-05-19 at 09:38, Andreas Jaeger wrote:
>ware; you can redistribute it and/or
> @@ -37,8 +37,8 @@ extern const char *const *__old_sys_errl
>
> const int __old_sys_nerr = OLD_ERRLIST_SIZE;
>
> -strong_alias (__old_sys_nerr, _old_sys_nerr);
> weak_alias (__old_sys_nerr, _old_sys_nerr)
> +strong_alias (__old_sys_nerr, _old_sys_nerr);
This doesn't look OK? Why is there a weak and a strong alias for the
same pair of names? Please test this patch:
Index: errlist.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/errlist.c,v
retrieving revision 1.8
diff -d -u -p -r1.8 errlist.c
--- errlist.c 6 Jul 2001 04:56:12 -0000 1.8
+++ errlist.c 20 May 2002 06:40:44 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1998, 2000 Free Software Foundation, Inc.
+/* Copyright (C) 1998, 2000, 2002 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -38,10 +38,9 @@ extern const char *const *__old_sys_errl
const int __old_sys_nerr = OLD_ERRLIST_SIZE;
strong_alias (__old_sys_nerr, _old_sys_nerr);
-weak_alias (__old_sys_nerr, _old_sys_nerr)
compat_symbol (libc, __old_sys_nerr, _sys_nerr, GLIBC_2_0);
compat_symbol (libc, _old_sys_nerr, sys_nerr, GLIBC_2_0);
-weak_alias (__old_sys_errlist, _old_sys_errlist);
+strong_alias (__old_sys_errlist, _old_sys_errlist);
compat_symbol (libc, __old_sys_errlist, _sys_errlist, GLIBC_2_0);
compat_symbol (libc, _old_sys_errlist, sys_errlist, GLIBC_2_0);
#endif
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]
next prev parent reply other threads:[~2002-05-20 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-19 9:38 Andreas Jaeger
2002-05-19 12:18 ` Roland McGrath
2002-05-19 23:14 ` Andreas Jaeger
2002-05-19 23:41 ` Ulrich Drepper [this message]
2002-05-19 23:47 ` Andreas Jaeger
2002-05-19 23:55 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1021876858.28991.167.camel@myware.mynet \
--to=drepper@redhat.com \
--cc=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).