From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10352 invoked by alias); 20 May 2002 06:41:05 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 10323 invoked from network); 20 May 2002 06:41:04 -0000 Received: from unknown (HELO myware.mynet) (66.87.73.137) by sources.redhat.com with SMTP; 20 May 2002 06:41:04 -0000 Received: from myware.mynet (myware.mynet [192.168.7.70]) by myware.mynet (8.11.6/8.11.6) with ESMTP id g4K6ewW30334; Sun, 19 May 2002 23:40:58 -0700 Subject: Re: fix .../linux/errlist.c From: Ulrich Drepper To: Andreas Jaeger Cc: GNU libc hacker In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-T/djcPZ2ypQHyOBcTq2Q" Date: Sun, 19 May 2002 23:41:00 -0000 Message-Id: <1021876858.28991.167.camel@myware.mynet> Mime-Version: 1.0 X-SW-Source: 2002-05/txt/msg00031.txt.bz2 --=-T/djcPZ2ypQHyOBcTq2Q Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1953 On Sun, 2002-05-19 at 09:38, Andreas Jaeger wrote: >ware; you can redistribute it and/or > @@ -37,8 +37,8 @@ extern const char *const *__old_sys_errl >=20=20 > const int __old_sys_nerr =3D OLD_ERRLIST_SIZE; >=20=20 > -strong_alias (__old_sys_nerr, _old_sys_nerr); > weak_alias (__old_sys_nerr, _old_sys_nerr) > +strong_alias (__old_sys_nerr, _old_sys_nerr); This doesn't look OK? Why is there a weak and a strong alias for the same pair of names? Please test this patch: Index: errlist.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/errlist.c,v retrieving revision 1.8 diff -d -u -p -r1.8 errlist.c --- errlist.c 6 Jul 2001 04:56:12 -0000 1.8 +++ errlist.c 20 May 2002 06:40:44 -0000 @@ -1,4 +1,4 @@ -/* Copyright (C) 1998, 2000 Free Software Foundation, Inc. +/* Copyright (C) 1998, 2000, 2002 Free Software Foundation, Inc. This file is part of the GNU C Library. =20 The GNU C Library is free software; you can redistribute it and/or @@ -38,10 +38,9 @@ extern const char *const *__old_sys_errl const int __old_sys_nerr =3D OLD_ERRLIST_SIZE; =20 strong_alias (__old_sys_nerr, _old_sys_nerr); -weak_alias (__old_sys_nerr, _old_sys_nerr) compat_symbol (libc, __old_sys_nerr, _sys_nerr, GLIBC_2_0); compat_symbol (libc, _old_sys_nerr, sys_nerr, GLIBC_2_0); -weak_alias (__old_sys_errlist, _old_sys_errlist); +strong_alias (__old_sys_errlist, _old_sys_errlist); compat_symbol (libc, __old_sys_errlist, _sys_errlist, GLIBC_2_0); compat_symbol (libc, _old_sys_errlist, sys_errlist, GLIBC_2_0); #endif --=20 ---------------. ,-. 1325 Chesapeake Terrace Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA Red Hat `--' drepper at redhat.com `------------------------ --=-T/djcPZ2ypQHyOBcTq2Q Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 232 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQA86Jp62ijCOnn/RHQRAsqaAKDERyLrGW4nBHd0uhLUyNqHxNXy0wCdHoqL rjcW5z0GAnUkoZIcknWGoj8= =RySu -----END PGP SIGNATURE----- --=-T/djcPZ2ypQHyOBcTq2Q--