public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jeff Bailey <jbailey@raspberryginger.com>
To: Roland McGrath <roland@redhat.com>
Cc: Andreas Schwab <schwab@suse.de>, libc-hacker@sourceware.org
Subject: Re: Symbol redefinition bugs
Date: Tue, 22 Nov 2005 03:55:00 -0000	[thread overview]
Message-ID: <1132631703.26222.112.camel@localhost.localdomain> (raw)
In-Reply-To: <20051121210102.50B0A1809B9@magilla.sf.frob.com>

On lun, 2005-11-21 at 13:01 -0800, Roland McGrath wrote:
> > Done this way, readelf -a showed that the various symbols went from being
> > WEAK to being GLOBAL.
> 
> Which symbols?  Show the exact details you are talking about.

This is on powerpc-linux using readelf -a.
The "old" build, is CVS HEAD glibc as of 2005-11-17 using binutils
2.16.1.  The "new" build is CVS HEAD glibc from today, using binutils
CVS from 20051117.

old:
   617: 000d85ac    44 FUNC    WEAK   DEFAULT   10 socket@@GLIBC_2.0
   954: 000d807c    44 FUNC    WEAK   DEFAULT   10 bind@@GLIBC_2.0
  1014: 000d8550    52 FUNC    WEAK   DEFAULT   10 setsockopt@@GLIBC_2.0
  1253: 000d81c0    40 FUNC    WEAK   DEFAULT   10 listen@@GLIBC_2.0
  2184: 000d8160    44 FUNC    WEAK   DEFAULT   10
getsockname@@GLIBC_2.0

new:
   617: 000d861c    44 FUNC    WEAK   DEFAULT   10 socket@@GLIBC_2.0
   954: 000d80ec    44 FUNC    GLOBAL DEFAULT   10 bind@@GLIBC_2.0
  1014: 000d85c0    52 FUNC    GLOBAL DEFAULT   10 setsockopt@@GLIBC_2.0
  1253: 000d8230    40 FUNC    GLOBAL DEFAULT   10 listen@@GLIBC_2.0
  2184: 000d81d0    44 FUNC    GLOBAL DEFAULT   10
getsockname@@GLIBC_2.0

With the patch I offered, it keeps these symbols as weak on ppc.  I had
tested it against ppc and x86_64.

x86_64 also had these symbols as weak before, but i386 did not:

   944: 000b90f0    57 FUNC    GLOBAL DEFAULT   11 bind@@GLIBC_2.0
(etc)

If you want bind, setsockopt, listen, and getsockname as weak, I'll redo
the patch against current CVS and resubmit.

Tks,
Jeff Bailey

  reply	other threads:[~2005-11-22  3:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-18 19:19 Andreas Schwab
2005-11-20 12:46 ` Jeff Bailey
2005-11-20 14:38   ` Andreas Schwab
2005-11-21 21:01   ` Roland McGrath
2005-11-22  3:55     ` Jeff Bailey [this message]
2005-11-22  4:33       ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1132631703.26222.112.camel@localhost.localdomain \
    --to=jbailey@raspberryginger.com \
    --cc=libc-hacker@sourceware.org \
    --cc=roland@redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).