From: David Mosberger <davidm@napali.hpl.hp.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
Roland McGrath <roland@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Set __libc_stack_end earlier on all arches, export back at GLIBC_2.1
Date: Wed, 24 Sep 2003 19:20:00 -0000 [thread overview]
Message-ID: <16241.61056.949014.678340@napali.hpl.hp.com> (raw)
In-Reply-To: <20030924134704.GK12344@sunsite.ms.mff.cuni.cz>
>>>>> On Wed, 24 Sep 2003 15:47:04 +0200, Jakub Jelinek <jakub@redhat.com> said:
Jakub> Also, for ia64, the __libc_stack_end setting code in
Jakub> RTLD_START should be removed, but removing of that requires
Jakub> rebundling the whole assembly.
You mean something along these lines? (In my opinion, the explicit
bundling should be removed in such assembly code. It only hurts
readability.)
--david
Index: sysdeps/ia64/dl-machine.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/ia64/dl-machine.h,v
retrieving revision 1.28
diff -u -r1.28 dl-machine.h
--- sysdeps/ia64/dl-machine.h 18 Aug 2003 22:04:56 -0000 1.28
+++ sysdeps/ia64/dl-machine.h 24 Sep 2003 18:57:03 -0000
@@ -318,21 +318,14 @@
" .save ar.pfs, r32\n" \
" .body\n" \
" { .mii\n" \
-" /* Save the pointer to the user entry point fptr in loc2. */\n" \
-" mov loc2 = ret0\n" \
-" /* Store the highest stack address. */\n" \
-" addl r2 = @ltoff(__libc_stack_end#), gp\n" \
" addl r3 = @gprel(_dl_skip_args), gp\n" \
-" ;;\n" \
-" }\n" \
-" { .mmi\n" \
-" ld8 r2 = [r2]\n" \
-" ld4 r3 = [r3]\n" \
" adds r11 = 24, sp /* Load the address of argv. */\n" \
+" /* Save the pointer to the user entry point fptr in loc2. */\n" \
+" mov loc2 = ret0\n" \
" ;;\n" \
" }\n" \
" { .mii\n" \
-" st8 [r2] = sp\n" \
+" ld4 r3 = [r3]\n" \
" adds r10 = 16, sp /* Load the address of argc. */\n" \
" mov out2 = r11\n" \
" ;;\n" \
@@ -401,7 +394,7 @@
" br.call.sptk.many b0 = _dl_init_internal#\n" \
" ;;\n" \
" }\n" \
-" /* Pass our finializer function to the user,\n" \
+" /* Pass our finalizer function to the user,\n" \
" and jump to the user's entry point. */\n" \
" { .mmi\n" \
" ld8 r3 = [loc2], 8\n" \
next prev parent reply other threads:[~2003-09-24 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 17:22 Jakub Jelinek
2003-09-24 19:20 ` David Mosberger [this message]
2003-09-24 20:50 ` Jakub Jelinek
2003-09-24 21:32 ` Ulrich Drepper
2003-09-24 21:31 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16241.61056.949014.678340@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=davidm@hpl.hp.com \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).