From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12511 invoked by alias); 24 Sep 2003 19:20:35 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 12491 invoked from network); 24 Sep 2003 19:20:35 -0000 Received: from unknown (HELO palrel12.hp.com) (156.153.255.237) by sources.redhat.com with SMTP; 24 Sep 2003 19:20:35 -0000 Received: from hplms2.hpl.hp.com (hplms2.hpl.hp.com [15.0.152.33]) by palrel12.hp.com (Postfix) with ESMTP id A66A01C00D72; Wed, 24 Sep 2003 12:20:34 -0700 (PDT) Received: from napali.hpl.hp.com (napali.hpl.hp.com [15.4.89.123]) by hplms2.hpl.hp.com (8.12.9/8.12.9/HPL-PA Hub) with ESMTP id h8OJKXEb023238; Wed, 24 Sep 2003 12:20:34 -0700 (PDT) Received: from napali.hpl.hp.com (localhost [127.0.0.1]) by napali.hpl.hp.com (8.12.3/8.12.3/Debian-5) with ESMTP id h8OJKXHZ004069; Wed, 24 Sep 2003 12:20:33 -0700 Received: (from davidm@localhost) by napali.hpl.hp.com (8.12.3/8.12.3/Debian-5) id h8OJKXB3004065; Wed, 24 Sep 2003 12:20:33 -0700 From: David Mosberger MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16241.61056.949014.678340@napali.hpl.hp.com> Date: Wed, 24 Sep 2003 19:20:00 -0000 To: Jakub Jelinek Cc: Ulrich Drepper , Roland McGrath , Glibc hackers Subject: Re: [PATCH] Set __libc_stack_end earlier on all arches, export back at GLIBC_2.1 In-Reply-To: <20030924134704.GK12344@sunsite.ms.mff.cuni.cz> References: <20030924134704.GK12344@sunsite.ms.mff.cuni.cz> Reply-To: davidm@hpl.hp.com X-URL: http://www.hpl.hp.com/personal/David_Mosberger/ X-SW-Source: 2003-09/txt/msg00084.txt.bz2 >>>>> On Wed, 24 Sep 2003 15:47:04 +0200, Jakub Jelinek said: Jakub> Also, for ia64, the __libc_stack_end setting code in Jakub> RTLD_START should be removed, but removing of that requires Jakub> rebundling the whole assembly. You mean something along these lines? (In my opinion, the explicit bundling should be removed in such assembly code. It only hurts readability.) --david Index: sysdeps/ia64/dl-machine.h =================================================================== RCS file: /cvs/glibc/libc/sysdeps/ia64/dl-machine.h,v retrieving revision 1.28 diff -u -r1.28 dl-machine.h --- sysdeps/ia64/dl-machine.h 18 Aug 2003 22:04:56 -0000 1.28 +++ sysdeps/ia64/dl-machine.h 24 Sep 2003 18:57:03 -0000 @@ -318,21 +318,14 @@ " .save ar.pfs, r32\n" \ " .body\n" \ " { .mii\n" \ -" /* Save the pointer to the user entry point fptr in loc2. */\n" \ -" mov loc2 = ret0\n" \ -" /* Store the highest stack address. */\n" \ -" addl r2 = @ltoff(__libc_stack_end#), gp\n" \ " addl r3 = @gprel(_dl_skip_args), gp\n" \ -" ;;\n" \ -" }\n" \ -" { .mmi\n" \ -" ld8 r2 = [r2]\n" \ -" ld4 r3 = [r3]\n" \ " adds r11 = 24, sp /* Load the address of argv. */\n" \ +" /* Save the pointer to the user entry point fptr in loc2. */\n" \ +" mov loc2 = ret0\n" \ " ;;\n" \ " }\n" \ " { .mii\n" \ -" st8 [r2] = sp\n" \ +" ld4 r3 = [r3]\n" \ " adds r10 = 16, sp /* Load the address of argc. */\n" \ " mov out2 = r11\n" \ " ;;\n" \ @@ -401,7 +394,7 @@ " br.call.sptk.many b0 = _dl_init_internal#\n" \ " ;;\n" \ " }\n" \ -" /* Pass our finializer function to the user,\n" \ +" /* Pass our finalizer function to the user,\n" \ " and jump to the user's entry point. */\n" \ " { .mmi\n" \ " ld8 r3 = [loc2], 8\n" \