From: Richard Henderson <rth@twiddle.net>
To: Jakub Jelinek <jakub@redhat.com>
Cc: drepper@cygnus.com, libc-hacker@sourceware.cygnus.com
Subject: Re: [PATCH] shut up warnings in bits/string2.h
Date: Tue, 07 Dec 1999 18:41:00 -0000 [thread overview]
Message-ID: <19991207184120.D13790@twiddle.net> (raw)
In-Reply-To: <19991207220811.M515@mff.cuni.cz>
On Tue, Dec 07, 1999 at 10:08:11PM +0100, Jakub Jelinek wrote:
> * string/bits/string2.h (__memset_gc, __mempcpy_small, __strcpy_small,
> __stpcpy_small): Cast switch expressions to int to shut up compiler
> warnings.
The patch is wrong Jakub. Suppose you have a string of
length 0x1_0000_0001. You will truncate this to 1 and
do the wrong thing.
I know you are trying to silence the extra warnings from
gcc's -Wtraditional, but there's nothing to be done about
it except possibly nuking it from the compiler.
r~
next prev parent reply other threads:[~1999-12-07 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-07 13:02 Jakub Jelinek
1999-12-07 18:41 ` Richard Henderson [this message]
1999-12-07 23:41 ` Ulrich Drepper
1999-12-08 0:22 ` Jakub Jelinek
1999-12-08 0:34 ` Ulrich Drepper
1999-12-08 7:56 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19991207184120.D13790@twiddle.net \
--to=rth@twiddle.net \
--cc=drepper@cygnus.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).