public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: "H . J . Lu" <hjl@lucon.org>
To: Ulrich Drepper <drepper@cygnus.com>
Cc: GNU libc hacker <libc-hacker@sourceware.cygnus.com>
Subject: A guard patch for linuxthreads
Date: Sun, 19 Dec 1999 08:45:00 -0000	[thread overview]
Message-ID: <19991219084545.A17373@lucon.org> (raw)
In-Reply-To: <19991219082116.A17290@lucon.org>

On Sun, Dec 19, 1999 at 08:21:16AM -0800, H . J . Lu wrote:
> On Sat, Dec 18, 1999 at 11:53:25AM -0800, Ulrich Drepper wrote:
> > I'm back for now and checked in the changes I've made over the days.
> > Mainly I've taken most of the changes I got and applied them (some of
> > them modified, e.g., HJ's thread patch).
> > 
> 
> Can we also fix linuxthread in 2.1? Also I am not quite sure if we should
> put a guard page beyond the stack bottom. Shouldn't we use this or at least
> fix the comment?
> 
> 

I believe this patch is what we want.


H.J.
--- manager.c	Sun Dec 19 07:51:27 1999
+++ /tmp/manager.c	Sun Dec 19 08:43:59 1999
@@ -315,8 +315,8 @@ static int pthread_allocate_stack(const 
       else
         {
           /* Put a bad page at the bottom of the stack */
-          guardaddr = (void *)new_thread_bottom - stacksize;
           guardsize = attr->__guardsize;
+          guardaddr = (void *)new_thread_bottom - guardsize;
           if (mmap ((caddr_t) guardaddr, guardsize, 0, MAP_FIXED, -1, 0)
               == MAP_FAILED)
             {

  reply	other threads:[~1999-12-19  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-12-18 11:56 back for now Ulrich Drepper
1999-12-19  8:21 ` H . J . Lu
1999-12-19  8:45   ` H . J . Lu [this message]
1999-12-19 13:47 ` More on linuxthreads H . J . Lu
1999-12-19 13:53   ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19991219084545.A17373@lucon.org \
    --to=hjl@lucon.org \
    --cc=drepper@cygnus.com \
    --cc=libc-hacker@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).